Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python Poetry #113

Open
DustinMoriarty opened this issue Sep 16, 2024 · 1 comment
Open

Use Python Poetry #113

DustinMoriarty opened this issue Sep 16, 2024 · 1 comment

Comments

@DustinMoriarty
Copy link

DustinMoriarty commented Sep 16, 2024

Current Behavior

This library is using setuptools. Setuptools is fine. Lots of old projects still use it for legacy reasons. However, why use setuptools for a brand new python project?

Desired Behavior

connect-sdk-python uses python poetry. Why the regression to using setuptools for this project? Python poetry is simply a better tool because it fully manages the development and packaging environment lifecycle. We don't need to cobble together venv, setuptools, pip freeze and twine anymore.

Benefits & Value

  1. Better dependency resolution.
  2. Lock file integration for automatically pegged dependencies for development environment.
  3. Virtual Environment integration.
  4. Virtual environments outside of project folder.
  5. Configuration driven pyproject.toml file per PEP 621 instead of code driven setup.py.
  6. Heavily used by many major python projects now.
  7. Easier to teach new developers the correct flow. Less allowance for anti-patterns.

Additional information

No response

@MOmarMiraj
Copy link
Contributor

Hi Dustin,

Thanks for submitting your question and feedback. I agree with you that poetry is the better tool and setuptools is indeed a legacy tool. I will submit an internal ticket to perform the tool conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants