Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market Manipulations Widget #426

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

JediFaust
Copy link
Contributor

  • Added Market Manupulations Widget written with Chart.js
  • Added support to universal pairs: BTC, ETH and XRP
  • Tested in Github Pages in separate repo: website
    NOTE: Due to security restrictions in Hugo for environment variables, RAPID_KEY and RAPID_HOST secrets should be renamed as HUGO_RAPID_KEY and HUGO_RAPID_HOST accordingly

@JediFaust JediFaust linked an issue May 7, 2024 that may be closed by this pull request
@marina-chibizova
Copy link
Contributor

@JediFaust thanks for your solution, it looks good! some comments from my side:

  • General comment: some charts have no time indicator - it would make more sense to add some kind of timestamp there (ideally time selector, but not necessary)
  • Time of trade: I assume you aggregated some period of time on this chart, could you add some indication about what period exactly?
  • First digit distribution: this chart would make more sense with expected distribution according to Benford's law
  • Volume distribution: I'm a bit confused about this one, could you explain the logic behind it? Normally it should follow power law
  • Buy/sell ratio: not sure what may be the issue, but when switching between pairs, it takes more time than usual to update the chart.

@marina-chibizova
Copy link
Contributor

NOTE: Due to security restrictions in Hugo for environment variables, RAPID_KEY and RAPID_HOST secrets should be renamed as HUGO_RAPID_KEY and HUGO_RAPID_HOST accordingly

done

@JediFaust
Copy link
Contributor Author

Comments above were addressed:

  • Volume Distribution calculation issue was fixed
  • Added Expected First Digit Distribution bar
  • Added aggregated period to Time of Trade
  • Added aggregated period to Time of Trade

Notes:

  • Time indicator is shown on possible charts and specified in aggregated ones
  • Chart update time is little slower when switching pairs because it parses new data by API call. However, chart switching works faster, since all the data is loaded in the previous API call.

@JediFaust JediFaust merged commit 047ea7a into 1712n:main May 28, 2024
1 check passed
@marina-chibizova
Copy link
Contributor

/payout -f 1000

Copy link

Thanks, @JediFaust! 213627 characters were added/changed in this PR. At a rate of 3¢/char multiplied by 1x your contribution is worth $1000.00. @albina-at-inca will process your payment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Market Manipulations Widget
3 participants