From fdac2a8c4901b234270bd872b40964221d69ee4d Mon Sep 17 00:00:00 2001
From: 15knots <11367029+15knots@users.noreply.github.com>
Date: Fri, 10 Nov 2023 21:14:13 +0100
Subject: [PATCH] add help context for CMakePropertyTab

---
 de.marw.cmake4eclipse.mbs.ui/doc/help_contexts.xml         | 7 +++++--
 de.marw.cmake4eclipse.mbs.ui/plugin.xml                    | 7 ++++---
 .../src/de/marw/cmake4eclipse/mbs/ui/CMakePropertyTab.java | 2 +-
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/de.marw.cmake4eclipse.mbs.ui/doc/help_contexts.xml b/de.marw.cmake4eclipse.mbs.ui/doc/help_contexts.xml
index 84ebfa90..54a1f62d 100644
--- a/de.marw.cmake4eclipse.mbs.ui/doc/help_contexts.xml
+++ b/de.marw.cmake4eclipse.mbs.ui/doc/help_contexts.xml
@@ -1,11 +1,14 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <contexts>
    <context id="cmake_symbols_context">
-      <description>This page is used to set properties for specifying CMake cache entries.</description>
+      <description>This tab is used to specify which CMake cache entries are passed to cmake.</description>
       <topic href="doc/html/ref/cmake_symbols.html" label="CMake cache entries"/>
    </context>
+   <context id="cmake_options_tab_context">
+      <description>This tab is used to specify general options which are passed to cmake.</description>
+   </context>
    <context id="wb_general_tab_context">
-      <description>This page is used to set preferences for how and when cmake is run.</description>
+      <description>This tab is used to set preferences for how and when cmake is run.</description>
       <topic href="doc/html/ref/wb_general_tab.html" label="Preferences - General cmake commandline options"/>
    </context>
    <context id="wb_cache_entries_context">
diff --git a/de.marw.cmake4eclipse.mbs.ui/plugin.xml b/de.marw.cmake4eclipse.mbs.ui/plugin.xml
index 652893de..8f6c229c 100644
--- a/de.marw.cmake4eclipse.mbs.ui/plugin.xml
+++ b/de.marw.cmake4eclipse.mbs.ui/plugin.xml
@@ -44,6 +44,7 @@
       <tab
             class="de.marw.cmake4eclipse.mbs.ui.CMakePropertyTab"
             icon="icons/CMakeLogo.gif"
+            helpId="de.marw.cmake4eclipse.mbs.ui.cmake_properties_context"
             name="&amp;General"
             parent="de.marw.cmake4eclipse.mbs.ui.CMakePropertyPage">
       </tab>
@@ -297,15 +298,15 @@
      </tab>
       <tab
             class="de.marw.cmake4eclipse.mbs.ui.CMakePropertyTab"
-            helpId="cdt_u_prop_pns_src"
+            helpId="de.marw.cmake4eclipse.mbs.ui.cmake_properties_context"
             icon="icons/CMakeLogo.gif"
-            name="&amp;CMake options"
+            name="CMake &amp;options"
             parent="de.marw.cmake4eclipse.mbs.ui.slim.Page_CMake">
       </tab>
       <tab
             class="de.marw.cmake4eclipse.mbs.ui.CMakeSymbolsTab"
             helpId="de.marw.cmake4eclipse.mbs.ui.cmake_symbols"
-            name="&amp;CMake cache entries"
+            name="CMake &amp;cache entries"
             parent="de.marw.cmake4eclipse.mbs.ui.slim.Page_CMake">
       </tab>
   </extension>
diff --git a/de.marw.cmake4eclipse.mbs.ui/src/de/marw/cmake4eclipse/mbs/ui/CMakePropertyTab.java b/de.marw.cmake4eclipse.mbs.ui/src/de/marw/cmake4eclipse/mbs/ui/CMakePropertyTab.java
index 91ad2a56..1461b963 100644
--- a/de.marw.cmake4eclipse.mbs.ui/src/de/marw/cmake4eclipse/mbs/ui/CMakePropertyTab.java
+++ b/de.marw.cmake4eclipse.mbs.ui/src/de/marw/cmake4eclipse/mbs/ui/CMakePropertyTab.java
@@ -77,7 +77,7 @@ public class CMakePropertyTab extends QuirklessAbstractCPropertyTab {
 
   @Override
   protected void createControls(final Composite parent) {
-    super.setHelpContextId(Activator.PLUGIN_ID + ".TODO");
+    super.setHelpContextId(Activator.PLUGIN_ID + ".cmake_options_tab_context");
     super.createControls(parent);
     usercomp.setLayout(new GridLayout(2, false));
 //    usercomp.setBackground(BACKGROUND_FOR_USER_VAR);