Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filenames.config.js can not be customized in project root #347

Closed
1 task done
marcoluzi opened this issue Dec 13, 2023 · 2 comments
Closed
1 task done

filenames.config.js can not be customized in project root #347

marcoluzi opened this issue Dec 13, 2023 · 2 comments

Comments

@marcoluzi
Copy link
Contributor

Describe the bug

In your README.md, in the section customizing build paths it is statet, that the build paths and file names can be changed by placing a filenames.config.js in the project root. It seems like the toolkit is not checking if this file is available in the project root and requires its own default file. See here.

I suggest to implement a logic to check for a custom config file, like it is done with the config files for babel, stylelint, webpack etc.

Steps to Reproduce

  1. Create filenames.config.js in the project root.
  2. Change filenames.
  3. Build the project.

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nicholasio
Copy link
Member

That's for the catch I don't know why it wasn't checking for that path... it's not something we used very often so likely why it was overlooked for so long.

@nicholasio
Copy link
Member

Fixed in #355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants