From e909302898bedf4ca0c2ffd75f8a8b1cb6e343a9 Mon Sep 17 00:00:00 2001
From: Xavier Carron <33637571+xav-car@users.noreply.github.com>
Date: Mon, 7 Oct 2024 14:56:20 +0200
Subject: [PATCH 1/7] refactor(admin): use PixFilterBanner to display filters

---
 .../target-profiles/list-summary-items.gjs    | 66 +++++++++++--------
 .../authenticated/target-profiles/list.js     |  6 ++
 admin/app/styles/globals/page.scss            |  8 +++
 admin/app/styles/globals/table-admin.scss     |  3 +-
 .../authenticated/target-profiles/list.hbs    |  5 +-
 .../target-profiles/list-test.js              |  8 ++-
 .../target-profiles/list-items-test.gjs       | 15 +++--
 .../list-summary-items-test.gjs               |  6 +-
 admin/translations/en.json                    | 24 +++++++
 admin/translations/fr.json                    | 24 +++++++
 10 files changed, 125 insertions(+), 40 deletions(-)

diff --git a/admin/app/components/target-profiles/list-summary-items.gjs b/admin/app/components/target-profiles/list-summary-items.gjs
index 4ba1d94397c..f868d9230a8 100644
--- a/admin/app/components/target-profiles/list-summary-items.gjs
+++ b/admin/app/components/target-profiles/list-summary-items.gjs
@@ -1,46 +1,58 @@
+import PixFilterBanner from '@1024pix/pix-ui/components/pix-filter-banner';
 import PixInput from '@1024pix/pix-ui/components/pix-input';
 import PixPagination from '@1024pix/pix-ui/components/pix-pagination';
 import { fn } from '@ember/helper';
 import { LinkTo } from '@ember/routing';
 import Component from '@glimmer/component';
+import { t } from 'ember-intl';
 
 import formatDate from '../../helpers/format-date';
 
 export default class TargetProfileListSummaryItems extends Component {
-  searchedId = this.args.id;
-  searchedName = this.args.name;
+  get isClearFiltersButtonDisabled() {
+    return !this.args.id && !this.args.name;
+  }
 
   <template>
+    <PixFilterBanner
+      class="page-body-template__content"
+      @title={{t "common.filters.title"}}
+      aria-label={{t "pages.target-profiles.filters.aria-label"}}
+      @details={{t "pages.target-profiles.filters.count" count=@summaries.meta.rowCount}}
+      @clearFiltersLabel={{t "common.filters.actions.clear"}}
+      @onClearFilters={{@onResetFilter}}
+      @isClearFilterButtonDisabled={{this.isClearFiltersButtonDisabled}}
+    >
+      <PixInput
+        type="text"
+        value={{@id}}
+        oninput={{fn @triggerFiltering "id"}}
+        placeholder={{t "pages.target-profiles.filters.search-by-id.placeholder"}}
+        @screenReaderOnly={{true}}
+      >
+        <:label>{{t "pages.target-profiles.filters.search-by-id.name"}}</:label>
+      </PixInput>
+
+      <PixInput
+        type="text"
+        value={{@name}}
+        placeholder={{t "pages.target-profiles.filters.search-by-name.placeholder"}}
+        oninput={{fn @triggerFiltering "name"}}
+        @screenReaderOnly={{true}}
+      >
+        <:label>{{t "pages.target-profiles.filters.search-by-name.name"}}</:label>
+      </PixInput>
+    </PixFilterBanner>
+
     <div class="content-text content-text--small">
       <div class="table-admin">
         <table>
-
           <thead>
             <tr>
-              <th class="table__column table__column--id" id="target-profile-id">ID</th>
-              <th id="target-profile-name">Nom</th>
-              <th class="col-date">Date de création</th>
-              <th class="col-status" id="target-profile-status">Statut</th>
-            </tr>
-            <tr>
-              <td class="table__column table__column--id">
-                <PixInput
-                  type="text"
-                  value={{this.searchedId}}
-                  oninput={{fn @triggerFiltering "id"}}
-                  aria-label="Filtrer les profils cible par un id"
-                />
-              </td>
-              <td>
-                <PixInput
-                  type="text"
-                  value={{this.searchedName}}
-                  oninput={{fn @triggerFiltering "name"}}
-                  aria-label="Filtrer les profils cible par un nom"
-                />
-              </td>
-              <td></td>
-              <td></td>
+              <th class="table__column table__column--id">{{t "common.fields.id"}}</th>
+              <th>{{t "common.fields.name"}}</th>
+              <th class="col-date">{{t "common.fields.createdAt"}}</th>
+              <th class="col-status">{{t "common.fields.status"}}</th>
             </tr>
           </thead>
 
diff --git a/admin/app/controllers/authenticated/target-profiles/list.js b/admin/app/controllers/authenticated/target-profiles/list.js
index 71f3f2d9fed..f44ada53322 100644
--- a/admin/app/controllers/authenticated/target-profiles/list.js
+++ b/admin/app/controllers/authenticated/target-profiles/list.js
@@ -26,4 +26,10 @@ export default class ListController extends Controller {
   triggerFiltering(fieldName, event) {
     debounceTask(this, 'updateFilters', { [fieldName]: event.target.value }, this.DEBOUNCE_MS);
   }
+
+  @action
+  onResetFilter() {
+    this.id = null;
+    this.name = null;
+  }
 }
diff --git a/admin/app/styles/globals/page.scss b/admin/app/styles/globals/page.scss
index 40fa1b93533..58289eea2ab 100644
--- a/admin/app/styles/globals/page.scss
+++ b/admin/app/styles/globals/page.scss
@@ -73,4 +73,12 @@
       }
     }
   }
+
+  .page-body-template {
+    padding: var(--pix-spacing-8x);
+
+    &__content {
+      margin-bottom: var(--pix-spacing-8x);
+    }
+  }
 }
diff --git a/admin/app/styles/globals/table-admin.scss b/admin/app/styles/globals/table-admin.scss
index 998ef88850c..6af70a3712f 100644
--- a/admin/app/styles/globals/table-admin.scss
+++ b/admin/app/styles/globals/table-admin.scss
@@ -1,6 +1,7 @@
 /* stylelint-disable selector-class-pattern */
 .table-admin {
-  margin-bottom: $pix-spacing-s;
+  margin-bottom: var(--pix-spacing-2x);
+  background-color: var(--pix-neutral-0);
 
   thead label {
     margin-bottom: 0;
diff --git a/admin/app/templates/authenticated/target-profiles/list.hbs b/admin/app/templates/authenticated/target-profiles/list.hbs
index fe6e88ce662..74e22caf660 100644
--- a/admin/app/templates/authenticated/target-profiles/list.hbs
+++ b/admin/app/templates/authenticated/target-profiles/list.hbs
@@ -8,13 +8,14 @@
   </div>
 </header>
 
-<main class="page-body">
-  <section class="page-section">
+<main class="page-body-template">
+  <section>
     <TargetProfiles::ListSummaryItems
       @summaries={{@model}}
       @id={{this.id}}
       @name={{this.name}}
       @triggerFiltering={{this.triggerFiltering}}
+      @onResetFilter={{this.onResetFilter}}
     />
   </section>
 </main>
\ No newline at end of file
diff --git a/admin/tests/acceptance/authenticated/target-profiles/list-test.js b/admin/tests/acceptance/authenticated/target-profiles/list-test.js
index a5e443f4869..6d09ddfea29 100644
--- a/admin/tests/acceptance/authenticated/target-profiles/list-test.js
+++ b/admin/tests/acceptance/authenticated/target-profiles/list-test.js
@@ -1,13 +1,17 @@
 import { clickByName, visit } from '@1024pix/ember-testing-library';
 import { currentURL } from '@ember/test-helpers';
 import { setupMirage } from 'ember-cli-mirage/test-support';
+import { t } from 'ember-intl/test-support';
 import { setupApplicationTest } from 'ember-qunit';
 import { authenticateAdminMemberWithRole } from 'pix-admin/tests/helpers/test-init';
 import { module, test } from 'qunit';
 
+import setupIntl from '../../../helpers/setup-intl';
+
 module('Acceptance | Target Profiles | List', function (hooks) {
   setupApplicationTest(hooks);
   setupMirage(hooks);
+  setupIntl(hooks);
 
   module('When admin member is not logged in', function () {
     test('it should not be accessible by an unauthenticated user', async function (assert) {
@@ -104,7 +108,9 @@ module('Acceptance | Target Profiles | List', function (hooks) {
           const screen = await visit('/target-profiles/list?id=123');
 
           // then
-          assert.dom(screen.getByRole('textbox', { name: 'Filtrer les profils cible par un id' })).hasValue('123');
+          assert
+            .dom(screen.getByRole('textbox', { name: t('pages.target-profiles.filters.search-by-id.name') }))
+            .hasValue('123');
         });
       });
     });
diff --git a/admin/tests/integration/components/routes/authenticated/target-profiles/list-items-test.gjs b/admin/tests/integration/components/routes/authenticated/target-profiles/list-items-test.gjs
index c64c8ee68ae..a63e32dd9f0 100644
--- a/admin/tests/integration/components/routes/authenticated/target-profiles/list-items-test.gjs
+++ b/admin/tests/integration/components/routes/authenticated/target-profiles/list-items-test.gjs
@@ -1,10 +1,11 @@
 import { render } from '@1024pix/ember-testing-library';
-import { setupRenderingTest } from 'ember-qunit';
 import ListSummaryItems from 'pix-admin/components/target-profiles/list-summary-items';
 import { module, test } from 'qunit';
 
+import setupIntlRenderingTest, { t } from '../../../../../helpers/setup-intl-rendering';
+
 module('Integration | Component | routes/authenticated/target-profiles | list-items', function (hooks) {
-  setupRenderingTest(hooks);
+  setupIntlRenderingTest(hooks);
 
   const triggerFiltering = function () {};
   const goToTargetProfilePage = function () {};
@@ -18,9 +19,9 @@ module('Integration | Component | routes/authenticated/target-profiles | list-it
     );
 
     // then
-    assert.dom(screen.getByText('ID')).exists();
-    assert.dom(screen.getByText('Nom')).exists();
-    assert.dom(screen.getByText('Statut')).exists();
+    assert.ok(screen.getByText(t('common.fields.id')));
+    assert.ok(screen.getByText(t('common.fields.name')));
+    assert.ok(screen.getByText(t('common.fields.status')));
   });
 
   test('it should display search inputs', async function (assert) {
@@ -32,8 +33,8 @@ module('Integration | Component | routes/authenticated/target-profiles | list-it
     );
 
     // then
-    assert.dom(screen.getByRole('textbox', { name: 'Filtrer les profils cible par un id' })).exists();
-    assert.dom(screen.getByRole('textbox', { name: 'Filtrer les profils cible par un nom' })).exists();
+    assert.dom(screen.getByRole('textbox', { name: t('pages.target-profiles.filters.search-by-id.name') })).exists();
+    assert.dom(screen.getByRole('textbox', { name: t('pages.target-profiles.filters.search-by-name.name') })).exists();
   });
 
   test('it should display target profile summaries list', async function (assert) {
diff --git a/admin/tests/integration/components/target-profiles/list-summary-items-test.gjs b/admin/tests/integration/components/target-profiles/list-summary-items-test.gjs
index 21be1660452..7139f61ff7e 100644
--- a/admin/tests/integration/components/target-profiles/list-summary-items-test.gjs
+++ b/admin/tests/integration/components/target-profiles/list-summary-items-test.gjs
@@ -1,9 +1,11 @@
 import { render } from '@1024pix/ember-testing-library';
-import { setupRenderingTest } from 'ember-qunit';
 import ListSummaryItems from 'pix-admin/components/target-profiles/list-summary-items';
 import { module, test } from 'qunit';
+
+import setupIntlRenderingTest from '../../../helpers/setup-intl-rendering';
+
 module('Integration | Component | TargetProfiles::ListSummaryItems', function (hooks) {
-  setupRenderingTest(hooks);
+  setupIntlRenderingTest(hooks);
 
   const triggerFiltering = () => {};
 
diff --git a/admin/translations/en.json b/admin/translations/en.json
index 64d2a45eed5..3e154c58648 100644
--- a/admin/translations/en.json
+++ b/admin/translations/en.json
@@ -18,6 +18,18 @@
       "login-user-temporary-blocked-error": "You have reached too many failed login attempts. Please try again later or '<'a href=\"{url}\"'>'reset your password here'</a>'.",
       "organization-not-found-error": "The organization \"{organizationId}\" does not exist."
     },
+    "fields": {
+      "createdAt": "Date of creation",
+      "id": "ID",
+      "name": "Name",
+      "status": "Status"
+    },
+    "filters": {
+      "title": "Filters",
+      "actions": {
+        "clear": "Clear filters"
+      }
+    },
     "forms": {
       "loading": "Loading...",
       "mandatory": "Champ obligatoire",
@@ -642,6 +654,18 @@
           "success": "The target profile has been duplicated."
         }
       },
+      "filters": {
+        "aria-label": "Target profile filters",
+        "count": "{count, plural, =0 {0 target profile} =1 {1 target profile} other {{count} target profiles}}",
+        "search-by-id": {
+          "name": "Filter target profiles by ID",
+          "placeholder": "Search by ID"
+        },
+        "search-by-name": {
+          "name": "Filter target profiles by name",
+          "placeholder": "Search by name"
+        }
+      },
       "resettable-checkbox": {
         "label": "Allow resetting for evaluation-type campaigns when multiple submissions are enabled for the organisation"
       }
diff --git a/admin/translations/fr.json b/admin/translations/fr.json
index a0632917f50..29003674608 100644
--- a/admin/translations/fr.json
+++ b/admin/translations/fr.json
@@ -18,6 +18,18 @@
       "login-user-temporary-blocked-error": "Vous avez effectué trop de tentatives de connexion. Réessayez plus tard ou cliquez sur '<'a href=\"{url}\"'>'mot de passe oublié'</a>' pour le réinitialiser.",
       "organization-not-found-error": "L’organisation \"{organizationId}\" n’existe pas."
     },
+    "fields": {
+      "createdAt": "Date de création",
+      "id": "ID",
+      "name": "Nom",
+      "status": "Statut"
+    },
+    "filters": {
+      "title": "Filtres",
+      "actions": {
+        "clear": "Effacer les filtres"
+      }
+    },
     "forms": {
       "loading": "Chargement...",
       "mandatory": "Champ obligatoire",
@@ -659,6 +671,18 @@
           "success": "Le profil cible a bien été copié."
         }
       },
+      "filters": {
+        "aria-label": "Filtres sur les profils cibles",
+        "count": "{count, plural, =0 {0 profil cible} =1 {1 profil cible} other {{count} profils cibles}}",
+        "search-by-id": {
+          "name": "Filtrer les profils cible par un ID",
+          "placeholder": "Rechercher par ID"
+        },
+        "search-by-name": {
+          "name": "Filtrer les profils cible par un nom",
+          "placeholder": "Rechercher par nom"
+        }
+      },
       "resettable-checkbox": {
         "label": "Permettre la remise à zéro des acquis du profil cible"
       }

From acbe03f1869d978154a679c5347a7a18c31355ec Mon Sep 17 00:00:00 2001
From: Xavier Carron <33637571+xav-car@users.noreply.github.com>
Date: Mon, 7 Oct 2024 16:38:22 +0200
Subject: [PATCH 2/7] feat(api): add category on target profile summary admin
 route

---
 .../models/TargetProfileSummaryForAdmin.js    |  1 +
 ...et-profile-summary-for-admin-repository.js |  2 +-
 ...et-profile-summary-for-admin-serializer.js |  2 +-
 ...ofile-summary-for-admin-repository_test.js | 66 ++++++++++++++++---
 ...ofile-summary-for-admin-serializer_test.js |  4 ++
 .../build-target-profile-summary-for-admin.js |  2 +
 6 files changed, 66 insertions(+), 11 deletions(-)

diff --git a/api/src/prescription/target-profile/domain/models/TargetProfileSummaryForAdmin.js b/api/src/prescription/target-profile/domain/models/TargetProfileSummaryForAdmin.js
index 718e5170145..8c22eb063b7 100644
--- a/api/src/prescription/target-profile/domain/models/TargetProfileSummaryForAdmin.js
+++ b/api/src/prescription/target-profile/domain/models/TargetProfileSummaryForAdmin.js
@@ -6,6 +6,7 @@ class TargetProfileSummaryForAdmin {
     this.id = params.id;
     this.name = params.name;
     this.outdated = params.outdated;
+    this.category = params.category;
     this.createdAt = params.createdAt;
     this.#sharedOrganizationId = params.sharedOrganizationId;
     this.#ownerOrganizationId = params.ownerOrganizationId;
diff --git a/api/src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js b/api/src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js
index b418541bda5..b6c58aa80c5 100644
--- a/api/src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js
+++ b/api/src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js
@@ -5,7 +5,7 @@ import { TargetProfileSummaryForAdmin } from '../../domain/models/TargetProfileS
 
 const findPaginatedFiltered = async function ({ filter, page }) {
   const query = knex('target-profiles')
-    .select('id', 'name', 'outdated', 'createdAt')
+    .select('id', 'name', 'outdated', 'category', 'createdAt')
     .orderBy('outdated', 'ASC')
     .orderBy('name', 'ASC')
     .modify(_applyFilters, filter);
diff --git a/api/src/prescription/target-profile/infrastructure/serializers/jsonapi/target-profile-summary-for-admin-serializer.js b/api/src/prescription/target-profile/infrastructure/serializers/jsonapi/target-profile-summary-for-admin-serializer.js
index 6fb9270f09f..518b93de003 100644
--- a/api/src/prescription/target-profile/infrastructure/serializers/jsonapi/target-profile-summary-for-admin-serializer.js
+++ b/api/src/prescription/target-profile/infrastructure/serializers/jsonapi/target-profile-summary-for-admin-serializer.js
@@ -4,7 +4,7 @@ const { Serializer } = jsonapiSerializer;
 
 const serialize = function (targetProfileSummaries, meta) {
   return new Serializer('target-profile-summary', {
-    attributes: ['name', 'outdated', 'createdAt', 'canDetach'],
+    attributes: ['name', 'outdated', 'createdAt', 'category', 'canDetach'],
     meta,
   }).serialize(targetProfileSummaries);
 };
diff --git a/api/tests/prescription/target-profile/integration/infrastructure/repositories/target-profile-summary-for-admin-repository_test.js b/api/tests/prescription/target-profile/integration/infrastructure/repositories/target-profile-summary-for-admin-repository_test.js
index 91411a401a1..991916c8989 100644
--- a/api/tests/prescription/target-profile/integration/infrastructure/repositories/target-profile-summary-for-admin-repository_test.js
+++ b/api/tests/prescription/target-profile/integration/infrastructure/repositories/target-profile-summary-for-admin-repository_test.js
@@ -1,11 +1,17 @@
 import * as targetProfileSummaryForAdminRepository from '../../../../../../src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js';
+import { TargetProfile } from '../../../../../../src/shared/domain/models/TargetProfile.js';
 import { databaseBuilder, domainBuilder, expect } from '../../../../../test-helper.js';
-
 describe('Integration | Repository | Target-profile-summary-for-admin', function () {
   describe('#findPaginatedFiltered', function () {
     it('return TargetProfileSummaryForAdmins model', async function () {
       // given
-      const targetProfile = { id: 1, name: 'Go go target profile', outdated: false, createdAt: new Date('2021-01-01') };
+      const targetProfile = {
+        id: 1,
+        name: 'Go go target profile',
+        outdated: false,
+        createdAt: new Date('2021-01-01'),
+        category: TargetProfile.categories.PREDEFINED,
+      };
       databaseBuilder.factory.buildTargetProfile(targetProfile);
       await databaseBuilder.commit();
 
@@ -145,10 +151,34 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
         let targetProfileData;
         beforeEach(function () {
           targetProfileData = [
-            { id: 1, name: 'paTtErN', outdated: false, createdAt: new Date('2021-01-01') },
-            { id: 2, name: 'AApatterNOo', outdated: true, createdAt: new Date('2021-01-01') },
-            { id: 3, name: 'NotUnderTheRadar', outdated: false, createdAt: new Date('2021-01-01') },
-            { id: 4, name: 'PaTternXXXX', outdated: true, createdAt: new Date('2021-01-01') },
+            {
+              id: 1,
+              name: 'paTtErN',
+              outdated: false,
+              createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.DISCIPLINE,
+            },
+            {
+              id: 2,
+              name: 'AApatterNOo',
+              outdated: true,
+              createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.DISCIPLINE,
+            },
+            {
+              id: 3,
+              name: 'NotUnderTheRadar',
+              outdated: false,
+              createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.DISCIPLINE,
+            },
+            {
+              id: 4,
+              name: 'PaTternXXXX',
+              outdated: true,
+              createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.DISCIPLINE,
+            },
           ];
           targetProfileData.map(databaseBuilder.factory.buildTargetProfile);
           return databaseBuilder.commit();
@@ -173,18 +203,21 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
               name: 'paTtErN',
               outdated: false,
               createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.DISCIPLINE,
             }),
             domainBuilder.buildTargetProfileSummaryForAdmin({
               id: 2,
               name: 'AApatterNOo',
               outdated: true,
               createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.DISCIPLINE,
             }),
             domainBuilder.buildTargetProfileSummaryForAdmin({
               id: 4,
               name: 'PaTternXXXX',
               outdated: true,
               createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.DISCIPLINE,
             }),
           ];
           expect(actualTargetProfileSummaries).to.deepEqualArray(expectedTargetProfileSummaries);
@@ -194,7 +227,13 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
         let targetProfileData;
         beforeEach(function () {
           targetProfileData = [
-            { id: 1, name: 'TPA', outdated: false, createdAt: new Date('2021-01-01') },
+            {
+              id: 1,
+              name: 'TPA',
+              outdated: false,
+              createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.PIX_PLUS,
+            },
             { id: 11, name: 'TPB', outdated: true, createdAt: new Date('2021-01-01') },
             { id: 21, name: 'TPC', outdated: false, createdAt: new Date('2021-01-01') },
             { id: 4, name: 'TPD', outdated: true, createdAt: new Date('2021-01-01') },
@@ -222,6 +261,7 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
               name: 'TPA',
               outdated: false,
               createdAt: new Date('2021-01-01'),
+              category: TargetProfile.categories.PIX_PLUS,
             }),
           ];
           expect(actualTargetProfileSummaries).to.deepEqualArray(expectedTargetProfileSummaries);
@@ -287,8 +327,16 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
 
       // then
       const expectedTargetProfileSummaries = [
-        domainBuilder.buildTargetProfileSummaryForAdmin({ ...targetProfile1, createdAt: undefined }),
-        domainBuilder.buildTargetProfileSummaryForAdmin({ ...targetProfile2, createdAt: undefined }),
+        domainBuilder.buildTargetProfileSummaryForAdmin({
+          ...targetProfile1,
+          createdAt: undefined,
+          category: undefined,
+        }),
+        domainBuilder.buildTargetProfileSummaryForAdmin({
+          ...targetProfile2,
+          createdAt: undefined,
+          category: undefined,
+        }),
       ];
       expect(targetProfileSummaries).to.deepEqualArray(expectedTargetProfileSummaries);
     });
diff --git a/api/tests/prescription/target-profile/unit/infrastructure/serializers/jsonapi/target-profile-summary-for-admin-serializer_test.js b/api/tests/prescription/target-profile/unit/infrastructure/serializers/jsonapi/target-profile-summary-for-admin-serializer_test.js
index 48810ecd6e0..53a63f903f7 100644
--- a/api/tests/prescription/target-profile/unit/infrastructure/serializers/jsonapi/target-profile-summary-for-admin-serializer_test.js
+++ b/api/tests/prescription/target-profile/unit/infrastructure/serializers/jsonapi/target-profile-summary-for-admin-serializer_test.js
@@ -10,11 +10,13 @@ describe('Unit | Serializer | JSONAPI | target-profile-serializer', function ()
           id: 1,
           name: 'TPA',
           outdated: false,
+          category: 'OTHER',
           createdAt: new Date('2021-01-01'),
         }),
         domainBuilder.buildTargetProfileSummaryForAdmin({
           id: 2,
           name: 'TPB',
+          category: 'POUET',
           outdated: true,
           createdAt: new Date('2021-01-01'),
         }),
@@ -33,6 +35,7 @@ describe('Unit | Serializer | JSONAPI | target-profile-serializer', function ()
             attributes: {
               name: 'TPA',
               outdated: false,
+              category: 'OTHER',
               'created-at': new Date('2021-01-01'),
               'can-detach': false,
             },
@@ -42,6 +45,7 @@ describe('Unit | Serializer | JSONAPI | target-profile-serializer', function ()
             id: '2',
             attributes: {
               name: 'TPB',
+              category: 'POUET',
               outdated: true,
               'created-at': new Date('2021-01-01'),
               'can-detach': false,
diff --git a/api/tests/tooling/domain-builder/factory/build-target-profile-summary-for-admin.js b/api/tests/tooling/domain-builder/factory/build-target-profile-summary-for-admin.js
index 273bb60317a..8bcfe6178b7 100644
--- a/api/tests/tooling/domain-builder/factory/build-target-profile-summary-for-admin.js
+++ b/api/tests/tooling/domain-builder/factory/build-target-profile-summary-for-admin.js
@@ -3,6 +3,7 @@ import { TargetProfileSummaryForAdmin } from '../../../../src/prescription/targe
 const buildTargetProfileSummaryForAdmin = function ({
   id = 123,
   name = 'Profil cible super cool',
+  category,
   outdated = false,
   createdAt,
   ownerOrganizationId,
@@ -12,6 +13,7 @@ const buildTargetProfileSummaryForAdmin = function ({
     id,
     name,
     outdated,
+    category,
     createdAt,
     ownerOrganizationId,
     sharedOrganizationId,

From 8a7e06479b8bdba3afe16d64b71a0dfef6ab9f4a Mon Sep 17 00:00:00 2001
From: Xavier Carron <33637571+xav-car@users.noreply.github.com>
Date: Mon, 7 Oct 2024 16:38:44 +0200
Subject: [PATCH 3/7] feat(admin): display category on table

---
 .../target-profiles/list-summary-items.gjs    |  8 ++++---
 .../app/helpers/target-profile-categories.js  | 11 +++++++++
 admin/app/models/target-profile-summary.js    |  6 +++++
 admin/translations/en.json                    | 24 +++++++++++++++----
 admin/translations/fr.json                    | 22 ++++++++++++++---
 5 files changed, 61 insertions(+), 10 deletions(-)
 create mode 100644 admin/app/helpers/target-profile-categories.js

diff --git a/admin/app/components/target-profiles/list-summary-items.gjs b/admin/app/components/target-profiles/list-summary-items.gjs
index f868d9230a8..0ea4bd6523b 100644
--- a/admin/app/components/target-profiles/list-summary-items.gjs
+++ b/admin/app/components/target-profiles/list-summary-items.gjs
@@ -51,6 +51,7 @@ export default class TargetProfileListSummaryItems extends Component {
             <tr>
               <th class="table__column table__column--id">{{t "common.fields.id"}}</th>
               <th>{{t "common.fields.name"}}</th>
+              <th>{{t "common.fields.target-profile.category.name"}}</th>
               <th class="col-date">{{t "common.fields.createdAt"}}</th>
               <th class="col-status">{{t "common.fields.status"}}</th>
             </tr>
@@ -60,14 +61,15 @@ export default class TargetProfileListSummaryItems extends Component {
             <tbody>
               {{#each @summaries as |summary|}}
                 <tr aria-label="Profil cible">
-                  <td headers="target-profile-id" class="table__column table__column--id">{{summary.id}}</td>
-                  <td headers="target-profile-name">
+                  <td class="table__column table__column--id">{{summary.id}}</td>
+                  <td>
                     <LinkTo @route="authenticated.target-profiles.target-profile" @model={{summary.id}}>
                       {{summary.name}}
                     </LinkTo>
                   </td>
+                  <td class="table__column table__column--id">{{t summary.translationKeyCategory}}</td>
                   <td class="table__column">{{formatDate summary.createdAt}}</td>
-                  <td headers="target-profile-status" class="target-profile-table-column__status">
+                  <td class="target-profile-table-column__status">
                     {{if summary.outdated "Obsolète" "Actif"}}
                   </td>
                 </tr>
diff --git a/admin/app/helpers/target-profile-categories.js b/admin/app/helpers/target-profile-categories.js
new file mode 100644
index 00000000000..c82d4571feb
--- /dev/null
+++ b/admin/app/helpers/target-profile-categories.js
@@ -0,0 +1,11 @@
+export const categories = {
+  OTHER: 'common.fields.target-profile.category.tags.OTHER',
+  DISCIPLINE: 'common.fields.target-profile.category.tags.DISCIPLINE',
+  COMPETENCES: 'common.fields.target-profile.category.tags.COMPETENCES',
+  PREDEFINED: 'common.fields.target-profile.category.tags.PREDEFINED',
+  CUSTOM: 'common.fields.target-profile.category.tags.CUSTOM',
+  PIX_PLUS: 'common.fields.target-profile.category.tags.PIX_PLUS',
+  SUBJECT: 'common.fields.target-profile.category.tags.SUBJECT',
+  TARGETED: 'common.fields.target-profile.category.tags.TARGETED',
+  BACK_TO_SCHOOL: 'common.fields.target-profile.category.tags.BACK_TO_SCHOOL',
+};
diff --git a/admin/app/models/target-profile-summary.js b/admin/app/models/target-profile-summary.js
index d960dda2fb1..1dbadd17c0e 100644
--- a/admin/app/models/target-profile-summary.js
+++ b/admin/app/models/target-profile-summary.js
@@ -1,8 +1,14 @@
 import Model, { attr } from '@ember-data/model';
 
+import { categories } from '../helpers/target-profile-categories';
 export default class TargetProfileSummary extends Model {
   @attr() name;
   @attr() outdated;
+  @attr() category;
   @attr() createdAt;
   @attr() canDetach;
+
+  get translationKeyCategory() {
+    return categories[this.category];
+  }
 }
diff --git a/admin/translations/en.json b/admin/translations/en.json
index 3e154c58648..c0f55abbf79 100644
--- a/admin/translations/en.json
+++ b/admin/translations/en.json
@@ -19,10 +19,26 @@
       "organization-not-found-error": "The organization \"{organizationId}\" does not exist."
     },
     "fields": {
-      "createdAt": "Date of creation",
-      "id": "ID",
-      "name": "Name",
-      "status": "Status"
+      "createdAt": "creation date",
+      "id": "id",
+      "name": "name",
+      "status": "status",
+      "target-profile": {
+        "category": {
+          "name": "category",
+          "tags": {
+            "BACK_TO_SCHOOL": "Back to school",
+            "COMPETENCES": "Pix Competences",
+            "CUSTOM": "Created for you",
+            "DISCIPLINE": "Schools",
+            "OTHER": "Other",
+            "PIX_PLUS": "Pix+",
+            "PREDEFINED": "Ready-made",
+            "SUBJECT": "Subject",
+            "TARGETED": "Targeted"
+          }
+        }
+      }
     },
     "filters": {
       "title": "Filters",
diff --git a/admin/translations/fr.json b/admin/translations/fr.json
index 29003674608..05ffe20dc26 100644
--- a/admin/translations/fr.json
+++ b/admin/translations/fr.json
@@ -19,10 +19,26 @@
       "organization-not-found-error": "L’organisation \"{organizationId}\" n’existe pas."
     },
     "fields": {
-      "createdAt": "Date de création",
+      "target-profile": {
+        "category": {
+          "name": "catégorie",
+          "tags": {
+            "BACK_TO_SCHOOL": "Parcours de rentrée / 6e",
+            "COMPETENCES": "Les 16 compétences",
+            "CUSTOM": "Parcours sur-mesure",
+            "DISCIPLINE": "Disciplinaires",
+            "OTHER": "Autres",
+            "PIX_PLUS": "Pix+",
+            "PREDEFINED": "Parcours prédéfinis",
+            "SUBJECT": "Thématiques",
+            "TARGETED": "Parcours ciblés"
+          }
+        }
+      },
+      "createdAt": "date de création",
       "id": "ID",
-      "name": "Nom",
-      "status": "Statut"
+      "name": "nom",
+      "status": "statut"
     },
     "filters": {
       "title": "Filtres",

From f8f655ac703fe4895fe1ce0acb9430312228ba4c Mon Sep 17 00:00:00 2001
From: ThomasBazin <thomas.bazin@pix.fr>
Date: Wed, 9 Oct 2024 15:38:54 +0200
Subject: [PATCH 4/7] feat(api): add filter category

---
 ...et-profile-summary-for-admin-repository.js |   5 +-
 ...ofile-summary-for-admin-repository_test.js | 168 +++++++-----------
 2 files changed, 72 insertions(+), 101 deletions(-)

diff --git a/api/src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js b/api/src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js
index b6c58aa80c5..bbdd1ad163e 100644
--- a/api/src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js
+++ b/api/src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js
@@ -36,12 +36,15 @@ const findByTraining = async function ({ trainingId }) {
 export { findByTraining, findPaginatedFiltered };
 
 function _applyFilters(qb, filter) {
-  const { name, id } = filter;
+  const { name, id, categories } = filter;
   if (name) {
     qb.whereILike('name', `%${name}%`);
   }
   if (id) {
     qb.where({ id });
   }
+  if (categories) {
+    qb.whereIn('category', categories);
+  }
   return qb;
 }
diff --git a/api/tests/prescription/target-profile/integration/infrastructure/repositories/target-profile-summary-for-admin-repository_test.js b/api/tests/prescription/target-profile/integration/infrastructure/repositories/target-profile-summary-for-admin-repository_test.js
index 991916c8989..8015f3087ee 100644
--- a/api/tests/prescription/target-profile/integration/infrastructure/repositories/target-profile-summary-for-admin-repository_test.js
+++ b/api/tests/prescription/target-profile/integration/infrastructure/repositories/target-profile-summary-for-admin-repository_test.js
@@ -1,6 +1,7 @@
 import * as targetProfileSummaryForAdminRepository from '../../../../../../src/prescription/target-profile/infrastructure/repositories/target-profile-summary-for-admin-repository.js';
 import { TargetProfile } from '../../../../../../src/shared/domain/models/TargetProfile.js';
 import { databaseBuilder, domainBuilder, expect } from '../../../../../test-helper.js';
+
 describe('Integration | Repository | Target-profile-summary-for-admin', function () {
   describe('#findPaginatedFiltered', function () {
     it('return TargetProfileSummaryForAdmins model', async function () {
@@ -147,46 +148,39 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
     });
 
     context('when passing a filter', function () {
+      let disciplineTargetProfile, otherTargetProfile, backToSchoolTargetProfile;
+      beforeEach(function () {
+        disciplineTargetProfile = {
+          id: 1,
+          name: 'TP DISCIPLINE',
+          outdated: false,
+          createdAt: new Date('2021-01-01'),
+          category: TargetProfile.categories.DISCIPLINE,
+        };
+        otherTargetProfile = {
+          id: 2,
+          name: 'TP OTHER',
+          outdated: true,
+          createdAt: new Date('2021-01-01'),
+          category: TargetProfile.categories.OTHER,
+        };
+        backToSchoolTargetProfile = {
+          id: 3,
+          name: 'TP BACK_TO_SCHOOL',
+          outdated: false,
+          createdAt: new Date('2021-01-01'),
+          category: TargetProfile.categories.BACK_TO_SCHOOL,
+        };
+
+        [disciplineTargetProfile, otherTargetProfile, backToSchoolTargetProfile].map(
+          databaseBuilder.factory.buildTargetProfile,
+        );
+        return databaseBuilder.commit();
+      });
       context('name filter', function () {
-        let targetProfileData;
-        beforeEach(function () {
-          targetProfileData = [
-            {
-              id: 1,
-              name: 'paTtErN',
-              outdated: false,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.DISCIPLINE,
-            },
-            {
-              id: 2,
-              name: 'AApatterNOo',
-              outdated: true,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.DISCIPLINE,
-            },
-            {
-              id: 3,
-              name: 'NotUnderTheRadar',
-              outdated: false,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.DISCIPLINE,
-            },
-            {
-              id: 4,
-              name: 'PaTternXXXX',
-              outdated: true,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.DISCIPLINE,
-            },
-          ];
-          targetProfileData.map(databaseBuilder.factory.buildTargetProfile);
-          return databaseBuilder.commit();
-        });
-
-        it('should return only target profiles matching "name" pattern in filter', async function () {
+        it('should return only target profiles matching "name" discipline in filter', async function () {
           // given
-          const filter = { name: 'pattern' };
+          const filter = { name: 'discipline' };
           const page = { number: 1, size: 10 };
 
           // when
@@ -197,51 +191,10 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
             });
 
           // then
-          const expectedTargetProfileSummaries = [
-            domainBuilder.buildTargetProfileSummaryForAdmin({
-              id: 1,
-              name: 'paTtErN',
-              outdated: false,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.DISCIPLINE,
-            }),
-            domainBuilder.buildTargetProfileSummaryForAdmin({
-              id: 2,
-              name: 'AApatterNOo',
-              outdated: true,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.DISCIPLINE,
-            }),
-            domainBuilder.buildTargetProfileSummaryForAdmin({
-              id: 4,
-              name: 'PaTternXXXX',
-              outdated: true,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.DISCIPLINE,
-            }),
-          ];
-          expect(actualTargetProfileSummaries).to.deepEqualArray(expectedTargetProfileSummaries);
+          expect(actualTargetProfileSummaries).to.deep.include(disciplineTargetProfile);
         });
       });
       context('id filter', function () {
-        let targetProfileData;
-        beforeEach(function () {
-          targetProfileData = [
-            {
-              id: 1,
-              name: 'TPA',
-              outdated: false,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.PIX_PLUS,
-            },
-            { id: 11, name: 'TPB', outdated: true, createdAt: new Date('2021-01-01') },
-            { id: 21, name: 'TPC', outdated: false, createdAt: new Date('2021-01-01') },
-            { id: 4, name: 'TPD', outdated: true, createdAt: new Date('2021-01-01') },
-          ];
-          targetProfileData.map(databaseBuilder.factory.buildTargetProfile);
-          return databaseBuilder.commit();
-        });
-
         it('should return only target profiles with exact match ID', async function () {
           // given
           const filter = { id: 1 };
@@ -255,29 +208,44 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
             });
 
           // then
-          const expectedTargetProfileSummaries = [
-            domainBuilder.buildTargetProfileSummaryForAdmin({
-              id: 1,
-              name: 'TPA',
-              outdated: false,
-              createdAt: new Date('2021-01-01'),
-              category: TargetProfile.categories.PIX_PLUS,
-            }),
-          ];
-          expect(actualTargetProfileSummaries).to.deepEqualArray(expectedTargetProfileSummaries);
+          expect(actualTargetProfileSummaries).to.deep.includes(disciplineTargetProfile);
         });
       });
-      context('no match', function () {
-        let targetProfileData;
-        beforeEach(function () {
-          targetProfileData = [
-            { id: 1, name: 'HELLO', outdated: false },
-            { id: 2, name: 'SALUT', outdated: true },
-          ];
-          targetProfileData.map(databaseBuilder.factory.buildTargetProfile);
-          return databaseBuilder.commit();
+      context('category filter', function () {
+        it('should return only target profiles with matching category discipline', async function () {
+          // given
+          const filter = { categories: [TargetProfile.categories.DISCIPLINE, TargetProfile.categories.BACK_TO_SCHOOL] };
+          const page = { number: 1, size: 10 };
+
+          // when
+          const { models: actualTargetProfileSummaries } =
+            await targetProfileSummaryForAdminRepository.findPaginatedFiltered({
+              filter,
+              page,
+            });
+
+          // then
+
+          expect(actualTargetProfileSummaries[0]).to.deep.include(backToSchoolTargetProfile);
+          expect(actualTargetProfileSummaries[1]).to.deep.include(disciplineTargetProfile);
         });
 
+        it('should return not result', async function () {
+          // given
+          const filter = { categories: [TargetProfile.categories.COMPETENCES] };
+          const page = { number: 1, size: 10 };
+
+          // when
+          const { models: actualTargetProfileSummaries } =
+            await targetProfileSummaryForAdminRepository.findPaginatedFiltered({
+              filter,
+              page,
+            });
+          // then
+          expect(actualTargetProfileSummaries).to.have.lengthOf(0);
+        });
+      });
+      context('no match', function () {
         it('should return an empty array when no records match the filter', async function () {
           // given
           const filter = { name: 'COUCOU' };
@@ -291,7 +259,7 @@ describe('Integration | Repository | Target-profile-summary-for-admin', function
             });
 
           // then
-          expect(actualTargetProfileSummaries).to.deepEqualArray([]);
+          expect(actualTargetProfileSummaries).to.have.lengthOf(0);
         });
       });
     });

From 13cbd2105d1188fb36a009eec4b74b1eeffd3979 Mon Sep 17 00:00:00 2001
From: Xavier Carron <33637571+xav-car@users.noreply.github.com>
Date: Wed, 9 Oct 2024 16:41:40 +0200
Subject: [PATCH 5/7] feat(api) add categories filter on paginated target
 proflei summaries controller

---
 .../admin-target-profile-controller.js        |  20 ++-
 .../admin-target-profile-controller_test.js   | 126 ++++++++++++++----
 2 files changed, 116 insertions(+), 30 deletions(-)

diff --git a/api/src/prescription/target-profile/application/admin-target-profile-controller.js b/api/src/prescription/target-profile/application/admin-target-profile-controller.js
index ed56b9c0995..4372a34a2bf 100644
--- a/api/src/prescription/target-profile/application/admin-target-profile-controller.js
+++ b/api/src/prescription/target-profile/application/admin-target-profile-controller.js
@@ -143,26 +143,38 @@ const copyTargetProfile = withTransaction(async (request) => {
   return copiedTargetProfileId;
 });
 
-const findTargetProfileSummariesForAdmin = async function (request) {
+const findTargetProfileSummariesForAdmin = async function (
+  request,
+  _,
+  dependencies = { targetProfileSummaryForAdminSerializer },
+) {
   const organizationId = request.params.id;
   const targetProfileSummaries = await prescriptionTargetProfileUsecases.findOrganizationTargetProfileSummariesForAdmin(
     {
       organizationId,
     },
   );
-  return targetProfileSummaryForAdminSerializer.serialize(targetProfileSummaries);
+  return dependencies.targetProfileSummaryForAdminSerializer.serialize(targetProfileSummaries);
 };
 
-const findPaginatedFilteredTargetProfileSummariesForAdmin = async function (request) {
+const findPaginatedFilteredTargetProfileSummariesForAdmin = async function (
+  request,
+  _,
+  dependencies = { targetProfileSummaryForAdminSerializer },
+) {
   const options = request.query;
 
+  if (options.filter.categories && !Array.isArray(options.filter.categories)) {
+    options.filter.categories = [options.filter.categories];
+  }
+
   const { models: targetProfileSummaries, meta } =
     await prescriptionTargetProfileUsecases.findPaginatedFilteredTargetProfileSummariesForAdmin({
       filter: options.filter,
       page: options.page,
     });
 
-  return targetProfileSummaryForAdminSerializer.serialize(targetProfileSummaries, meta);
+  return dependencies.targetProfileSummaryForAdminSerializer.serialize(targetProfileSummaries, meta);
 };
 
 const targetProfileController = {
diff --git a/api/tests/prescription/target-profile/unit/application/admin-target-profile-controller_test.js b/api/tests/prescription/target-profile/unit/application/admin-target-profile-controller_test.js
index 44f6adffc96..9f615afeab9 100644
--- a/api/tests/prescription/target-profile/unit/application/admin-target-profile-controller_test.js
+++ b/api/tests/prescription/target-profile/unit/application/admin-target-profile-controller_test.js
@@ -303,9 +303,92 @@ describe('Unit | Controller | admin-target-profile-controller', function () {
       expect(
         prescriptionTargetProfileUsecases.findPaginatedFilteredTargetProfileSummariesForAdmin,
       ).to.have.been.calledWithExactly(useCaseParameters);
-      expect(response).to.deep.equal({
-        meta: {},
-        data: [{ attributes: models[0], type: 'target-profile-summaries' }],
+      expect(response).to.deep.equal(expectedResult);
+    });
+
+    describe('categories filter', function () {
+      it('should not transform filter categories if already an array', async function () {
+        // given
+        const models = [{ name: Symbol('targetProfileSummariesName') }];
+        const meta = Symbol('meta');
+        const filter = {
+          categories: ['TOTO'],
+        };
+        const page = { size: 2, number: 1 };
+        const useCaseParameters = { filter, page };
+        const expectedResult = Symbol('serialized-paginated-filtered-target-profile-summaries');
+
+        sinon.stub(prescriptionTargetProfileUsecases, 'findPaginatedFilteredTargetProfileSummariesForAdmin').resolves({
+          models,
+          meta,
+        });
+
+        const targetProfileSummaryForAdminSerializer = {
+          serialize: sinon.stub(),
+        };
+
+        targetProfileSummaryForAdminSerializer.serialize.withArgs(models, meta).returns(expectedResult);
+
+        // when
+        await targetProfileController.findPaginatedFilteredTargetProfileSummariesForAdmin(
+          {
+            query: useCaseParameters,
+          },
+          hFake,
+          { targetProfileSummaryForAdminSerializer },
+        );
+
+        // then
+        expect(
+          prescriptionTargetProfileUsecases.findPaginatedFilteredTargetProfileSummariesForAdmin.calledWithExactly({
+            filter: {
+              categories: ['TOTO'],
+            },
+            page,
+          }),
+        ).to.be.true;
+      });
+
+      it('should transform string filter categories to array', async function () {
+        // given
+        const models = [{ name: Symbol('targetProfileSummariesName') }];
+        const meta = Symbol('meta');
+        const filter = {
+          categories: 'TOTO',
+        };
+        const page = { size: 2, number: 1 };
+        const useCaseParameters = { filter, page };
+        const expectedResult = Symbol('serialized-paginated-filtered-target-profile-summaries');
+
+        sinon.stub(prescriptionTargetProfileUsecases, 'findPaginatedFilteredTargetProfileSummariesForAdmin').resolves({
+          models,
+          meta,
+        });
+
+        const targetProfileSummaryForAdminSerializer = {
+          serialize: sinon.stub(),
+        };
+
+        targetProfileSummaryForAdminSerializer.serialize.withArgs(models, meta).returns(expectedResult);
+
+        // when
+        await targetProfileController.findPaginatedFilteredTargetProfileSummariesForAdmin(
+          {
+            query: useCaseParameters,
+          },
+          hFake,
+          { targetProfileSummaryForAdminSerializer },
+        );
+
+        // then
+        expect(
+          prescriptionTargetProfileUsecases.findPaginatedFilteredTargetProfileSummariesForAdmin.calledWithExactly({
+            filter: {
+              categories: ['TOTO'],
+            },
+            page,
+          }),
+        ).to.be.true;
       });
     });
   });
@@ -313,37 +396,28 @@ describe('Unit | Controller | admin-target-profile-controller', function () {
   describe('#findTargetProfileSummariesForAdmin', function () {
     it('should return serialized summaries', async function () {
       // given
+      const expectedResult = Symbol('serialized-target-profile-summaries');
       sinon.stub(prescriptionTargetProfileUsecases, 'findOrganizationTargetProfileSummariesForAdmin');
       const request = {
-        params: { id: 123 },
+        params: { id: Symbol('oranizationId') },
+      };
+      const targetProfileSummary = Symbol('targetProfileSummary');
+      const targetProfileSummaryForAdminSerializer = {
+        serialize: sinon.stub(),
       };
-      const targetProfileSummary = domainBuilder.buildTargetProfileSummaryForAdmin({
-        id: 456,
-        name: 'Super profil cible',
-        outdated: false,
-      });
       prescriptionTargetProfileUsecases.findOrganizationTargetProfileSummariesForAdmin
-        .withArgs({ organizationId: 123 })
-        .resolves([targetProfileSummary]);
+        .withArgs({ organizationId: request.params.id })
+        .resolves(targetProfileSummary);
+
+      targetProfileSummaryForAdminSerializer.serialize.withArgs(targetProfileSummary).returns(expectedResult);
 
       // when
-      const response = await targetProfileController.findTargetProfileSummariesForAdmin(request);
+      const response = await targetProfileController.findTargetProfileSummariesForAdmin(request, null, {
+        targetProfileSummaryForAdminSerializer,
+      });
 
       // then
-      expect(response).to.deep.equal({
-        data: [
-          {
-            type: 'target-profile-summaries',
-            id: '456',
-            attributes: {
-              name: 'Super profil cible',
-              outdated: false,
-              'can-detach': false,
-              'created-at': undefined,
-            },
-          },
-        ],
-      });
+      expect(response).to.deep.equal(expectedResult);
     });
   });
 });

From 0c16fdc4f03418712430c898246b551dddec55b7 Mon Sep 17 00:00:00 2001
From: LionelB <lionel@lumographe.fr>
Date: Thu, 10 Oct 2024 09:22:23 +0200
Subject: [PATCH 6/7] feat(api): allow categorie filter on admin target profile
 summary route

---
 .../shared/domain/types/identifiers-type.js   |  2 +
 .../application/admin-target-profile-route.js |  2 +
 .../trainings/training-controller_test.js     |  1 +
 .../admin-target-profile-route_test.js        | 48 ++++++++++++++-----
 .../admin-target-profiles-route_test.js       |  3 +-
 5 files changed, 42 insertions(+), 14 deletions(-)

diff --git a/api/src/prescription/shared/domain/types/identifiers-type.js b/api/src/prescription/shared/domain/types/identifiers-type.js
index df057992bc4..6b55d9f849f 100644
--- a/api/src/prescription/shared/domain/types/identifiers-type.js
+++ b/api/src/prescription/shared/domain/types/identifiers-type.js
@@ -1,9 +1,11 @@
 import Joi from 'joi';
 
+import { categories } from '../../../../shared/domain/models/TargetProfile.js';
 import { certificabilityByLabel } from '../../application/helpers.js';
 
 const filterType = {
   certificability: Joi.string().valid(...Object.keys(certificabilityByLabel)),
+  targetProfileCategory: Joi.string().valid(...Object.values(categories)),
 };
 
 export { filterType };
diff --git a/api/src/prescription/target-profile/application/admin-target-profile-route.js b/api/src/prescription/target-profile/application/admin-target-profile-route.js
index cb241acad52..261d1fa4ac0 100644
--- a/api/src/prescription/target-profile/application/admin-target-profile-route.js
+++ b/api/src/prescription/target-profile/application/admin-target-profile-route.js
@@ -3,6 +3,7 @@ import Joi from 'joi';
 import { BadRequestError, NotFoundError, sendJsonApiError } from '../../../shared/application/http-errors.js';
 import { securityPreHandlers } from '../../../shared/application/security-pre-handlers.js';
 import { identifiersType, optionalIdentifiersType } from '../../../shared/domain/types/identifiers-type.js';
+import { filterType } from '../../shared/domain/types/identifiers-type.js';
 import { targetProfileController } from './admin-target-profile-controller.js';
 
 const register = async function (server) {
@@ -374,6 +375,7 @@ const register = async function (server) {
             filter: Joi.object({
               id: Joi.number().integer().empty('').allow(null).optional(),
               name: Joi.string().empty('').allow(null).optional(),
+              categories: [filterType.targetProfileCategory, Joi.array().items(filterType.targetProfileCategory)],
             }).default({}),
             page: Joi.object({
               number: Joi.number().integer().empty('').allow(null).optional(),
diff --git a/api/tests/devcomp/acceptance/application/trainings/training-controller_test.js b/api/tests/devcomp/acceptance/application/trainings/training-controller_test.js
index d94761f6e58..5e21523deb8 100644
--- a/api/tests/devcomp/acceptance/application/trainings/training-controller_test.js
+++ b/api/tests/devcomp/acceptance/application/trainings/training-controller_test.js
@@ -458,6 +458,7 @@ describe('Acceptance | Controller | training-controller', function () {
           outdated: false,
           'created-at': undefined,
           'can-detach': false,
+          category: undefined,
         },
       };
 
diff --git a/api/tests/prescription/target-profile/acceptance/application/admin-target-profile-route_test.js b/api/tests/prescription/target-profile/acceptance/application/admin-target-profile-route_test.js
index b8c421ba77d..f40d823d6a3 100644
--- a/api/tests/prescription/target-profile/acceptance/application/admin-target-profile-route_test.js
+++ b/api/tests/prescription/target-profile/acceptance/application/admin-target-profile-route_test.js
@@ -1,3 +1,4 @@
+import * as TargetProfile from '../../../../../src/shared/domain/models/TargetProfile.js';
 import {
   createServer,
   databaseBuilder,
@@ -567,20 +568,41 @@ describe('Acceptance | TargetProfile | Application | Route | admin-target-profil
 
       // then
       expect(response.statusCode).to.equal(200);
-      expect(response.result).to.deep.equal({
-        data: [
-          {
-            type: 'target-profile-summaries',
-            id: '1',
-            attributes: {
-              name: 'Super profil cible',
-              outdated: false,
-              'created-at': undefined,
-              'can-detach': false,
-            },
-          },
-        ],
+      expect(response.result.data).to.have.lengthOf(1);
+    });
+  });
+
+  describe('GET /api/admin/target-profile-summaries', function () {
+    let userId;
+    let organizationId;
+
+    beforeEach(async function () {
+      userId = databaseBuilder.factory.buildUser.withRole().id;
+      organizationId = databaseBuilder.factory.buildOrganization().id;
+      databaseBuilder.factory.buildTargetProfile({
+        id: 1,
+        ownerOrganizationId: organizationId,
+        name: 'Super profil cible',
+        outdated: false,
+        category: TargetProfile.categories.OTHER,
       });
+      await databaseBuilder.commit();
+    });
+
+    it('should return serialized target profile summaries', async function () {
+      // given
+      const options = {
+        method: 'GET',
+        url: `/api/admin/target-profile-summaries`,
+        headers: { authorization: generateValidRequestAuthorizationHeader(userId) },
+      };
+
+      // when
+      const response = await server.inject(options);
+
+      // then
+      expect(response.statusCode).to.equal(200);
+      expect(response.result.data).to.have.lengthOf(1);
     });
   });
 });
diff --git a/api/tests/prescription/target-profile/unit/application/admin-target-profiles-route_test.js b/api/tests/prescription/target-profile/unit/application/admin-target-profiles-route_test.js
index 7c5065d086d..b1c0842b7be 100644
--- a/api/tests/prescription/target-profile/unit/application/admin-target-profiles-route_test.js
+++ b/api/tests/prescription/target-profile/unit/application/admin-target-profiles-route_test.js
@@ -1,6 +1,7 @@
 import { targetProfileController } from '../../../../../src/prescription/target-profile/application/admin-target-profile-controller.js';
 import * as moduleUnderTest from '../../../../../src/prescription/target-profile/application/admin-target-profile-route.js';
 import { securityPreHandlers } from '../../../../../src/shared/application/security-pre-handlers.js';
+import { categories } from '../../../../../src/shared/domain/models/TargetProfile.js';
 import { expect, HttpTestServer, sinon } from '../../../../test-helper.js';
 
 describe('Unit | Application | Admin Target Profiles | Routes', function () {
@@ -1072,7 +1073,7 @@ describe('Unit | Application | Admin Target Profiles | Routes', function () {
         // when
         const response = await httpTestServer.request(
           method,
-          `${url}?filter[id]=1&filter[name]=azerty&page[size]=10&page[number]=1`,
+          `${url}?filter[id]=1&filter[name]=azerty&filter[categories][]=${categories.COMPETENCES}&filter[categories][]=${categories.OTHER}&page[size]=10&page[number]=1`,
         );
 
         // then

From 3bfc39ce517c21d975ac1e2f51a66b1d024c9157 Mon Sep 17 00:00:00 2001
From: LionelB <lionel@lumographe.fr>
Date: Thu, 10 Oct 2024 14:19:48 +0200
Subject: [PATCH 7/7] feat(admin): add campaign filter

---
 .../target-profiles/list-summary-items.gjs    | 32 ++++++-
 .../authenticated/target-profiles/list.js     |  4 +-
 .../authenticated/target-profiles/list.js     |  3 +
 .../authenticated/target-profiles/list.hbs    |  1 +
 .../list-summary-items-test.gjs               | 93 ++++++++++++++++++-
 .../target-profiles/list-test.js              | 86 +++++++++++++++++
 .../target-profiles/list-test.js              | 31 ++++---
 admin/translations/en.json                    |  4 +
 admin/translations/fr.json                    |  4 +
 9 files changed, 244 insertions(+), 14 deletions(-)
 create mode 100644 admin/tests/unit/controllers/authenticated/target-profiles/list-test.js

diff --git a/admin/app/components/target-profiles/list-summary-items.gjs b/admin/app/components/target-profiles/list-summary-items.gjs
index 0ea4bd6523b..cbb158a3a1d 100644
--- a/admin/app/components/target-profiles/list-summary-items.gjs
+++ b/admin/app/components/target-profiles/list-summary-items.gjs
@@ -1,16 +1,34 @@
 import PixFilterBanner from '@1024pix/pix-ui/components/pix-filter-banner';
 import PixInput from '@1024pix/pix-ui/components/pix-input';
+import PixMultiSelect from '@1024pix/pix-ui/components/pix-multi-select';
 import PixPagination from '@1024pix/pix-ui/components/pix-pagination';
 import { fn } from '@ember/helper';
+import { action } from '@ember/object';
 import { LinkTo } from '@ember/routing';
+import { service } from '@ember/service';
 import Component from '@glimmer/component';
+import { tracked } from '@glimmer/tracking';
 import { t } from 'ember-intl';
 
 import formatDate from '../../helpers/format-date';
+import { categories } from '../../helpers/target-profile-categories.js';
 
 export default class TargetProfileListSummaryItems extends Component {
+  @service intl;
+  @tracked selectedValues = [];
+
   get isClearFiltersButtonDisabled() {
-    return !this.args.id && !this.args.name;
+    return !this.args.id && !this.args.name && !this.args.categories;
+  }
+
+  get categoryOptions() {
+    const categTest = Object.entries(categories).map(([key, value]) => ({ label: this.intl.t(value), value: key }));
+    return categTest;
+  }
+
+  @action
+  triggerCategoriesFiltering(values) {
+    this.args.triggerFiltering('categories', { target: { value: values } });
   }
 
   <template>
@@ -42,6 +60,18 @@ export default class TargetProfileListSummaryItems extends Component {
       >
         <:label>{{t "pages.target-profiles.filters.search-by-name.name"}}</:label>
       </PixInput>
+      <PixMultiSelect
+        @id="categories"
+        @screenReaderOnly={{true}}
+        @placeholder={{t "common.filters.target-profile.placeholder"}}
+        @onChange={{this.triggerCategoriesFiltering}}
+        @values={{@categories}}
+        @options={{this.categoryOptions}}
+      >
+        <:label>{{t "common.filters.target-profile.label"}}</:label>
+        <:default as |option|>{{option.label}}</:default>
+      </PixMultiSelect>
+
     </PixFilterBanner>
 
     <div class="content-text content-text--small">
diff --git a/admin/app/controllers/authenticated/target-profiles/list.js b/admin/app/controllers/authenticated/target-profiles/list.js
index f44ada53322..5ef72ec36c8 100644
--- a/admin/app/controllers/authenticated/target-profiles/list.js
+++ b/admin/app/controllers/authenticated/target-profiles/list.js
@@ -7,13 +7,14 @@ import config from 'pix-admin/config/environment';
 const DEFAULT_PAGE_NUMBER = 1;
 
 export default class ListController extends Controller {
-  queryParams = ['pageNumber', 'pageSize', 'id', 'name'];
+  queryParams = ['pageNumber', 'pageSize', 'id', 'name', 'categories'];
   DEBOUNCE_MS = config.pagination.debounce;
 
   @tracked pageNumber = DEFAULT_PAGE_NUMBER;
   @tracked pageSize = 10;
   @tracked id = null;
   @tracked name = null;
+  @tracked categories = [];
 
   updateFilters(filters) {
     for (const filterKey of Object.keys(filters)) {
@@ -31,5 +32,6 @@ export default class ListController extends Controller {
   onResetFilter() {
     this.id = null;
     this.name = null;
+    this.categories = [];
   }
 }
diff --git a/admin/app/routes/authenticated/target-profiles/list.js b/admin/app/routes/authenticated/target-profiles/list.js
index a65de34a542..777463ce0e1 100644
--- a/admin/app/routes/authenticated/target-profiles/list.js
+++ b/admin/app/routes/authenticated/target-profiles/list.js
@@ -12,6 +12,7 @@ export default class ListRoute extends Route {
     pageSize: { refreshModel: true },
     id: { refreshModel: true },
     name: { refreshModel: true },
+    categories: { refreshModel: true },
   };
 
   beforeModel() {
@@ -25,6 +26,7 @@ export default class ListRoute extends Route {
         filter: {
           id: params.id ? params.id.trim() : '',
           name: params.name ? params.name.trim() : '',
+          categories: params.categories ?? [],
         },
         page: {
           number: params.pageNumber,
@@ -46,6 +48,7 @@ export default class ListRoute extends Route {
       controller.pageSize = 10;
       controller.id = null;
       controller.name = null;
+      controller.categories = [];
     }
   }
 }
diff --git a/admin/app/templates/authenticated/target-profiles/list.hbs b/admin/app/templates/authenticated/target-profiles/list.hbs
index 74e22caf660..b6a9e0fc481 100644
--- a/admin/app/templates/authenticated/target-profiles/list.hbs
+++ b/admin/app/templates/authenticated/target-profiles/list.hbs
@@ -14,6 +14,7 @@
       @summaries={{@model}}
       @id={{this.id}}
       @name={{this.name}}
+      @categories={{this.categories}}
       @triggerFiltering={{this.triggerFiltering}}
       @onResetFilter={{this.onResetFilter}}
     />
diff --git a/admin/tests/integration/components/target-profiles/list-summary-items-test.gjs b/admin/tests/integration/components/target-profiles/list-summary-items-test.gjs
index 7139f61ff7e..52aa9401389 100644
--- a/admin/tests/integration/components/target-profiles/list-summary-items-test.gjs
+++ b/admin/tests/integration/components/target-profiles/list-summary-items-test.gjs
@@ -1,6 +1,9 @@
-import { render } from '@1024pix/ember-testing-library';
+import { render, within } from '@1024pix/ember-testing-library';
+import { t } from 'ember-intl/test-support';
 import ListSummaryItems from 'pix-admin/components/target-profiles/list-summary-items';
+import { categories as CATEGORIES } from 'pix-admin/helpers/target-profile-categories.js';
 import { module, test } from 'qunit';
+import sinon from 'sinon';
 
 import setupIntlRenderingTest from '../../../helpers/setup-intl-rendering';
 
@@ -38,4 +41,92 @@ module('Integration | Component | TargetProfiles::ListSummaryItems', function (h
     assert.dom(screen.getByText('01/01/2021')).exists();
     assert.dom(screen.getByText('Actif')).exists();
   });
+
+  module('filter', function () {
+    test('it should display categories filter', async function (assert) {
+      // given
+      const summaries = [];
+      summaries.meta = { page: 1, pageSize: 1 };
+      const id = undefined;
+      const name = undefined;
+      const categories = undefined;
+
+      // when
+      const screen = await render(
+        <template>
+          <ListSummaryItems
+            @id={{id}}
+            @summaries={{summaries}}
+            @name={{name}}
+            @categories={{categories}}
+            @triggerFiltering={{triggerFiltering}}
+          />
+        </template>,
+      );
+
+      // then
+      assert.ok(screen.getByLabelText(t('common.filters.target-profile.label')));
+    });
+
+    test('it should display selected categories', async function (assert) {
+      // given
+      const summaries = [];
+      summaries.meta = { page: 1, pageSize: 1 };
+      const id = undefined;
+      const name = undefined;
+      const categories = ['OTHER'];
+
+      // when
+      const screen = await render(
+        <template>
+          <ListSummaryItems
+            @id={{id}}
+            @summaries={{summaries}}
+            @name={{name}}
+            @categories={{categories}}
+            @triggerFiltering={{triggerFiltering}}
+          />
+        </template>,
+      );
+
+      // then
+      const domNode = screen.getByLabelText(t('common.filters.target-profile.label'));
+      await domNode.click();
+      const menu = await screen.findByRole('menu');
+      const checkbox = within(menu).getByRole('checkbox', { name: t(CATEGORIES.OTHER) });
+      assert.true(checkbox.checked);
+    });
+
+    test('it should call triggerFiltering', async function (assert) {
+      // given
+      const summaries = [];
+      summaries.meta = { page: 1, pageSize: 1 };
+      const id = undefined;
+      const name = undefined;
+      const categories = [];
+
+      const triggerFilteringSpy = sinon.spy();
+
+      // when
+      const screen = await render(
+        <template>
+          <ListSummaryItems
+            @id={{id}}
+            @summaries={{summaries}}
+            @name={{name}}
+            @categories={{categories}}
+            @triggerFiltering={{triggerFilteringSpy}}
+          />
+        </template>,
+      );
+
+      // then
+      const domNode = screen.getByLabelText(t('common.filters.target-profile.label'));
+      await domNode.click();
+      const menu = await screen.findByRole('menu');
+      const checkbox = within(menu).getByRole('checkbox', { name: t(CATEGORIES.OTHER) });
+      await checkbox.click();
+      assert.true(triggerFilteringSpy.calledWithExactly('categories', { target: { value: ['OTHER'] } }));
+    });
+  });
 });
diff --git a/admin/tests/unit/controllers/authenticated/target-profiles/list-test.js b/admin/tests/unit/controllers/authenticated/target-profiles/list-test.js
new file mode 100644
index 00000000000..a7b1fdf14ff
--- /dev/null
+++ b/admin/tests/unit/controllers/authenticated/target-profiles/list-test.js
@@ -0,0 +1,86 @@
+import { setupTest } from 'ember-qunit';
+import { module, test } from 'qunit';
+
+module('Unit | Controller | authenticated/target-profiles/list', function (hooks) {
+  setupTest(hooks);
+  let controller;
+
+  hooks.beforeEach(function () {
+    controller = this.owner.lookup('controller:authenticated.target-profiles.list');
+  });
+
+  module('#updateFilters', function () {
+    module('resetting page number', function () {
+      test('it should reset page number', async function (assert) {
+        // given
+        controller.pageNumber = 10;
+        const expectedValue = 1;
+
+        // when
+        await controller.updateFilters({});
+
+        // then
+        assert.strictEqual(controller.pageNumber, expectedValue);
+      });
+    });
+
+    module('updating name', function () {
+      test('it should update controller name field', async function (assert) {
+        // given
+        controller.name = 'someName';
+        const expectedValue = 'someOtherName';
+
+        // when
+        await controller.updateFilters({ name: expectedValue });
+
+        // then
+        assert.strictEqual(controller.name, expectedValue);
+      });
+    });
+
+    module('updating id', function () {
+      test('it should update controller id field', async function (assert) {
+        // given
+        controller.id = 'someId';
+        const expectedValue = 'someOtherId';
+
+        // when
+        await controller.updateFilters({ id: expectedValue });
+
+        // then
+        assert.strictEqual(controller.id, expectedValue);
+      });
+    });
+
+    module('updating categories', function () {
+      test('it should update controller categories field', async function (assert) {
+        // given
+        controller.categories = ['someCategories'];
+        const expectedValue = ['someOtherCategories'];
+
+        // when
+        await controller.updateFilters({ categories: expectedValue });
+
+        // then
+        assert.strictEqual(controller.categories, expectedValue);
+      });
+    });
+  });
+
+  module('#onResetFilter', function () {
+    test('it should reset controller filter', async function (assert) {
+      // given
+      controller.name = 'someName';
+      controller.id = 'someId';
+      controller.categories = ['someCategories'];
+
+      // when
+      await controller.onResetFilter();
+
+      // then
+      assert.strictEqual(controller.name, null);
+      assert.strictEqual(controller.id, null);
+      assert.strictEqual(controller.categories.length, 0);
+    });
+  });
+});
diff --git a/admin/tests/unit/routes/authenticated/target-profiles/list-test.js b/admin/tests/unit/routes/authenticated/target-profiles/list-test.js
index 3970d2b945b..f828ccd28eb 100644
--- a/admin/tests/unit/routes/authenticated/target-profiles/list-test.js
+++ b/admin/tests/unit/routes/authenticated/target-profiles/list-test.js
@@ -14,9 +14,11 @@ module('Unit | Route | authenticated/target-profiles/list', function (hooks) {
   module('#model', function (hooks) {
     const params = {};
     const expectedQueryArgs = {};
+    let queryStub;
 
     hooks.beforeEach(function () {
-      route.store.query = sinon.stub().resolves();
+      // route.store.query = sinon.stub().resolves();
+      queryStub = sinon.stub(route.store, 'query').resolves();
       params.pageNumber = 'somePageNumber';
       params.pageSize = 'somePageSize';
       expectedQueryArgs.page = {
@@ -32,6 +34,7 @@ module('Unit | Route | authenticated/target-profiles/list', function (hooks) {
         expectedQueryArgs.filter = {
           name: '',
           id: '',
+          categories: [],
         };
 
         // then
@@ -45,17 +48,20 @@ module('Unit | Route | authenticated/target-profiles/list', function (hooks) {
         // given
         params.name = ' someName';
         params.id = 'someId ';
+        params.categories = ['OTHER'];
         expectedQueryArgs.filter = {
           name: 'someName',
           id: 'someId',
+          categories: ['OTHER'],
         };
 
         // when
         await route.model(params);
 
         // then
-        sinon.assert.calledWith(route.store.query, 'target-profile-summary', expectedQueryArgs);
-        assert.ok(true);
+        console.log(queryStub);
+
+        assert.ok(queryStub.calledWith('target-profile-summary', expectedQueryArgs));
       });
     });
   });
@@ -69,6 +75,7 @@ module('Unit | Route | authenticated/target-profiles/list', function (hooks) {
         pageSize: 'somePageSize',
         name: 'someName',
         id: 'someId',
+        categories: ['OTHER'],
       };
     });
 
@@ -78,10 +85,11 @@ module('Unit | Route | authenticated/target-profiles/list', function (hooks) {
         route.resetController(controller, true);
 
         // then
-        assert.deepEqual(controller.pageNumber, 1);
-        assert.deepEqual(controller.pageSize, 10);
-        assert.deepEqual(controller.name, null);
-        assert.deepEqual(controller.id, null);
+        assert.strictEqual(controller.pageNumber, 1);
+        assert.strictEqual(controller.pageSize, 10);
+        assert.strictEqual(controller.name, null);
+        assert.strictEqual(controller.id, null);
+        assert.strictEqual(controller.categories.length, 0);
       });
     });
 
@@ -91,10 +99,11 @@ module('Unit | Route | authenticated/target-profiles/list', function (hooks) {
         route.resetController(controller, false);
 
         // then
-        assert.deepEqual(controller.pageNumber, 'somePageNumber');
-        assert.deepEqual(controller.pageSize, 'somePageSize');
-        assert.deepEqual(controller.name, 'someName');
-        assert.deepEqual(controller.id, 'someId');
+        assert.strictEqual(controller.pageNumber, 'somePageNumber');
+        assert.strictEqual(controller.pageSize, 'somePageSize');
+        assert.strictEqual(controller.name, 'someName');
+        assert.strictEqual(controller.id, 'someId');
+        assert.deepEqual(controller.categories, ['OTHER']);
       });
     });
   });
diff --git a/admin/translations/en.json b/admin/translations/en.json
index c0f55abbf79..90e1293e513 100644
--- a/admin/translations/en.json
+++ b/admin/translations/en.json
@@ -44,6 +44,10 @@
       "title": "Filters",
       "actions": {
         "clear": "Clear filters"
+      },
+      "target-profile": {
+        "placeholder": "Pix+, Other ...",
+        "label": "Category"
       }
     },
     "forms": {
diff --git a/admin/translations/fr.json b/admin/translations/fr.json
index 05ffe20dc26..1b914dc310d 100644
--- a/admin/translations/fr.json
+++ b/admin/translations/fr.json
@@ -44,6 +44,10 @@
       "title": "Filtres",
       "actions": {
         "clear": "Effacer les filtres"
+      },
+      "target-profile": {
+        "placeholder": "Pix+, Autres...",
+        "label": "Catégorie"
       }
     },
     "forms": {