From e90d772297b06d20837876b4ac1a0c5b0b9dd625 Mon Sep 17 00:00:00 2001
From: Aniket Kadam <aniket.kadam@100ms.live>
Date: Thu, 27 Jun 2024 13:14:41 +0530
Subject: [PATCH] Update

---
 .github/workflows/android.yml | 2 +-
 app/build.gradle.kts          | 4 ++--
 gradle.properties             | 5 ++++-
 print_apk_table.py            | 9 +++++----
 4 files changed, 12 insertions(+), 8 deletions(-)
 mode change 100644 => 100755 print_apk_table.py

diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
index 4f60ab3..e82507d 100644
--- a/.github/workflows/android.yml
+++ b/.github/workflows/android.yml
@@ -34,4 +34,4 @@ jobs:
 
     - name: Create Table
       run: |
-        python print_apk_table.py >> $GITHUB_STEP_SUMMARY
+        ./print_apk_table.py >> $GITHUB_STEP_SUMMARY
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
index 4ec2a7d..088def9 100644
--- a/app/build.gradle.kts
+++ b/app/build.gradle.kts
@@ -153,8 +153,8 @@ dependencies {
     androidTestImplementation(libs.androidx.junit)
     androidTestImplementation(libs.androidx.espresso.core)
 
-    val hmsVersion = "2.9.59"
-    val roomKitVersion = "1.2.13"
+    val hmsVersion: String by project
+    val roomKitVersion: String by project
     
     "01-room-kitImplementation"("live.100ms:room-kit:$roomKitVersion")
     
diff --git a/gradle.properties b/gradle.properties
index 20e2a01..fb4c878 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -20,4 +20,7 @@ kotlin.code.style=official
 # Enables namespacing of each library's R class so that its R class includes only the
 # resources declared in the library itself and none from the library's dependencies,
 # thereby reducing the size of the R class for that library
-android.nonTransitiveRClass=true
\ No newline at end of file
+android.nonTransitiveRClass=true
+org.gradle.java.home=/Users/aniket/Applications/Android\ Studio.app/Contents/jbr/Contents/Home
+roomKitVersion=1.2.15
+hmsVersion=2.9.62
\ No newline at end of file
diff --git a/print_apk_table.py b/print_apk_table.py
old mode 100644
new mode 100755
index 47ce493..dbe0982
--- a/print_apk_table.py
+++ b/print_apk_table.py
@@ -1,3 +1,4 @@
+#!/usr/bin/env python3
 import re
 import subprocess
 import sys
@@ -10,7 +11,7 @@
 
 You can take a look at the reference project [here](https://github.com/100mslive/Android-Size-Reference-App/)
 
-These are accuarate for sdk version `2.9.59` and room-kit version `1.2.13`.
+These are accuarate for sdk version `HMS_SDK_VERSION_PLACEHOLDER` and room-kit version `HMS_ROOMKIT_VERSION_PLACEHOLDER`.
 
 ## Increase in Android APK size:
 
@@ -120,7 +121,7 @@ def writeDataToFile(data, filePath):
 		# Writing data to a file
 		doc.writelines(data)	
 
-def getArticleString():
+def getArticleString(version):
 	article = [prefixedArticle, archTableHeader,]
 	# Print everything except room kit and the base
 	for a in archMaps:
@@ -144,5 +145,5 @@ def printEntireArchTable():
 if(len(sys.argv) == 1):
 	printEntireArchTable()
 else:
-	print(f"Writing article to path: {sys.argv[1]}")
-	writeDataToFile(getArticleString(), sys.argv[1])
+	print(f"Writing article for version {sys.argv[2]} to path: {sys.argv[1]}")
+	writeDataToFile(getArticleString(sys.argv[2]), sys.argv[1])