Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change benchmark format #776

Open
0xaatif opened this issue Nov 6, 2024 · 0 comments
Open

Change benchmark format #776

0xaatif opened this issue Nov 6, 2024 · 0 comments
Milestone

Comments

@0xaatif
Copy link
Contributor

0xaatif commented Nov 6, 2024

          I think I'd prefer storing the data differently - how do you feel about saving off wide information as follows?

Get full information from time

/usr/bin/time \
  --format='{"command":"%C","avg_unshared_data_kb":%D,"elapsed_real_hms":"%E","pg_fault_io_major_ct":%F,"fs_inputs_ct":%I,"avg_mem_kb":%K,"max_rss_kb":%M,"fs_outputs_ct":%O,"cpu_pc":"%P","pg_fault_minor_ct":%R,"cpu_kernel_secs":%S,"cpu_user_secs":%U,"swap_ct":%W,"avg_shared_text_kb":%X,"system_pg_size_bytes":%Z,"ctx_switch_forced_ct":%c,"elapsed_real_secs":%e,"signals_recv_ct":%k,"avg_unshared_stack_kb":%p,"socket_recv_ct":%r,"socket_sent_ct":%s,"avg_rss_kb":%t,"ctx_switch_yield_ct":%w,"exit_status":%x}' \
  --output time.json \
  "$COMMAND" \
  "$ARGS"

Combine information as follows

{
  "commit": $hash,
  "date": $date,
  "runner": {
    "name": $runner,
    "cores": ...,
    "arch": ...,
  },
  "time": {
    // from time.json
  },
}

I would strongly prefer moving away from bash scripts too - can we do the above in xtask?

Originally posted by @0xaatif in #701 (review)

@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Nov 6, 2024
@atanmarko atanmarko added this to the x Misc. milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants