-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pin toolchain #660
Comments
Note we already do this for mdbook, not sure what the best upgrade strategy for this is (I don't think dependabot can handle it just yet) Could do a weekly cron-ed PR |
If we want to pin the toolchain (which may very well needed given latest mdbook issues and possibly unforeseen incoming ones), then I'd tend to opt for some cron-ed job to keep it relatively up-to-date, at least while we're heavily developing, but this seems tedious if we cannot automate the actual version bump. |
Would save us from rust-lang/rust-clippy#13458 |
$ git show --pretty=reference --no-patch
56e7d08e (feat: trie diff tool (#630), 2024-09-24)
$ for day in 25 26; do
> toolchain=nightly-2024-09-$day
> rustup install $toolchain &>/dev/null
> echo $toolchain
> CARGO_TARGET_DIR=target.$toolchain.ignoreme cargo +$toolchain clippy --all-targets --quiet
> done
nightly-2024-09-25
nightly-2024-09-26
warning: unneeded `return` statement
... |
(I promise I didn't break clippy to push this issue, despite the suspicious timing :D) |
WIBNI reproducible CI
https://github.com/0xPolygonZero/zk_evm/actions/runs/11017223235/job/30594596343
Here we fail on the default branch due to a compiler regression
The text was updated successfully, but these errors were encountered: