-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move circuit directory to common platform dependant directory #375
Comments
My opinion is #310 (comment) |
Just continuing the conversation from #310. @0xaatif from your proposal here, would the idea be that circuits are never serialized to disk without the user specifying this explicitly in the prog args? And I guess we would never attempt to look for serialized circuits if the user doesn't specify this in the args? Also @Nashtare wdyt about either using the output of |
Yes, we could keep things small and simple for now, like git's plumbing commands. We can do porcelain later. $ zero-bin generate-circuit memory 0..16 > mem.circuit
$ zero-bin get witness http://127.0
0.1/ > witness.json
$ zero-bin prove --witness witness.json --memory mem.circuit |
Yes that'd be a useful safeguard against discrepancies (though I think the circuit consistency file we had got lost somewhere in the migration or the recent PRs). |
Hmm... I personally feel we should hide the internals from the user by default (I think that's what you're saying you want in the end as well). Like already at this point we're abstracting this away to some extent (we read/write to the |
I'm good with that approach :) |
- Now attempts to use the OS's specific cache dir to store circuits. - This is done by setting the env var `ZK_EVM_CACHE_DIR` if the user has not already set it, which allows the user to override the circuit cache directory if they want to.
- Now attempts to use the OS's specific cache dir to store circuits. - This is done by setting the env var `ZK_EVM_CACHE_DIR` if the user has not already set it, which allows the user to override the circuit cache directory if they want to.
- Now attempts to use the OS's specific cache dir to store circuits. - This is done by setting the env var `ZK_EVM_CACHE_DIR` if the user has not already set it, which allows the user to override the circuit cache directory if they want to.
* Circuit cache dir now uses os cache dir (#375) - Now attempts to use the OS's specific cache dir to store circuits. - This is done by setting the env var `ZK_EVM_CACHE_DIR` if the user has not already set it, which allows the user to override the circuit cache directory if they want to. * Requested PR changes for #405 - No longer uses a lazy static. * Requested PR changes for #405 (2) - Fixed accidently not panicing when an `env` var is not set. * Fixed env var not being set in AMPQ mode * Requested PR changes for #405 (3)
* Circuit cache dir now uses os cache dir (#375) - Now attempts to use the OS's specific cache dir to store circuits. - This is done by setting the env var `ZK_EVM_CACHE_DIR` if the user has not already set it, which allows the user to override the circuit cache directory if they want to. * Requested PR changes for #405 - No longer uses a lazy static. * Requested PR changes for #405 (2) - Fixed accidently not panicing when an `env` var is not set. * Fixed env var not being set in AMPQ mode * Requested PR changes for #405 (3)
Based on the discussion here.
The text was updated successfully, but these errors were encountered: