chore: use npm ci for faster installs, and only run build once on pr …

…sync (push)
0x4007 · Oct 1, 2024 · a690f3b · a690f3b
1 parent 5ee489c
commit a690f3b
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 10 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,8 +1,8 @@
 name: Build
 
 on:
-  push:
   pull_request:
+    types: [opened, synchronize, reopened]
   workflow_dispatch:
 
 permissions:
@@ -21,10 +21,11 @@ jobs:
         with:
           node-version: 20.10.0
 
+      - name: Install dependencies
+        run: npm ci
+
       - name: Build
-        run: |
-          npm install
-          npm run build
+        run: npm run build
 
       - name: Upload build artifact
         uses: actions/upload-artifact@v4

diff --git a/.github/workflows/cspell.yml b/.github/workflows/cspell.yml
@@ -18,7 +18,7 @@ jobs:
           node-version: "20.10.0"
 
       - name: Install
-        run: npm install
+        run: npm ci
 
       - name: Run cspell
         run: npm run format:cspell
diff --git a/.github/workflows/cypress-testing.yml b/.github/workflows/cypress-testing.yml
@@ -16,7 +16,7 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
       - name: Install dependencies
-        run: npm install
+        run: npm ci
       - name: Cypress run
         uses: cypress-io/github-action@v6
         with:

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -25,4 +25,4 @@ jobs:
           commit_sha: ${{ github.event.workflow_run.head_sha }}
           workflow_run_id: ${{ github.event.workflow_run.id }}
           app_id: ${{ secrets.APP_ID }}
-          private_key: ${{ secrets.APP_PRIVATE_KEY }}
+          app_private_key: ${{ secrets.APP_PRIVATE_KEY }}
diff --git a/.github/workflows/dispatch.yml b/.github/workflows/dispatch.yml
@@ -21,7 +21,7 @@ jobs:
           node-version: "20.10.0"
 
       - name: Install dependencies
-        run: npm install
+        run: npm ci
 
       - name: Run npm start
         run: npm start "${{ github.event.inputs.input_string }}"

diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml
@@ -21,7 +21,7 @@ jobs:
 
       - name: Jest With Coverage
         run: |
-          npm install
+          npm ci
           npm run test
 
       - name: Add Jest Report to Summary

diff --git a/.github/workflows/knip.yml b/.github/workflows/knip.yml
@@ -16,7 +16,7 @@ jobs:
           node-version: 20.10.0
 
       - name: Install toolchain
-        run: npm install
+        run: npm ci
 
       - name: Store PR number
         run: echo ${{ github.event.number }} > pr-number.txt