Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launcher GUI doesn't work on Windows 7 installer (WontFix) #163

Open
2 tasks
drojf opened this issue Aug 20, 2021 · 0 comments
Open
2 tasks

Launcher GUI doesn't work on Windows 7 installer (WontFix) #163

drojf opened this issue Aug 20, 2021 · 0 comments
Labels
wontfix This will not be worked on

Comments

@drojf
Copy link
Collaborator

drojf commented Aug 20, 2021

The UI based launcher doesn't work on windows 7. You can still install using the text-mode installer, however.

I'm just recording that the reason for this is:

  • On Windows 7, the "job object" registration fails
  • the "job object" was introduced to make sure that when you close the installer UI, the aria2c process is killed (so that it doesn't keep downloading in the background). This is only necessary when using the UI, as when using console/text mode installer, closing the console window will terminate aria2c automatically
  • Therefore, even if the UI works, if the job object registration fails, we use the console/text mode installer, to make sure aria2c is killed if you close the installer (well, close the terminal). If we allowed the UI, we'd also be allowing the aria2c process to run in the background if you closed the UI window.

TODO:

  • Note this in the wiki
  • Add option to text mode installer to run from temp folder? This option is not given in the text mode installer.
@drojf drojf added the wontfix This will not be worked on label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant