Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BGM] hig_sample_kyouki.ogg has unpleasant and possibly damaging high pitched frequencies #54

Open
BFCE opened this issue May 13, 2020 · 4 comments

Comments

@BFCE
Copy link

BFCE commented May 13, 2020

This is present with and without 07th-mod

Steps to reproduce:
A. play BGM/hig_sample_kyouki.ogg
or
B. Load into this save file: save005.zip

The harsh noises are plainly heard around the 10 second mark

@ItaloKnox
Copy link
Member

ItaloKnox commented May 13, 2020

We talked yesterday on Discord, but I need to elaborate here further, so we can decide on what we're going with.

For everyone who is not aware, it is for a fact that the frequencies around 15kHz are way too much. It's so much you can't even read it:
Studio_One_2020-05-13_11-17-45

  • Here's the original

    • warning: turn down your volume around 00:40~01:00 and the very end
  • @BFCE's edit

    • I believe this is a competent edit but at the same time I think it cuts way too much from what is an intended effect, even if misused
  • My edit (version 1)

    • This version cuts only the most problematic frequency with a dynamic EQ bell using a very thin Q, meaning that only the exaggerated frequency will be toned down significantly, but not fully removed
  • My edit (version 2)

    • This version does the same as the first, but instead uses a wider Q, meaning that the cut will affect nearby frequencies in a lesser way. The cut was also reworked slightly, so a volume difference between both versions (in the cut area) will be noticeable. This version also has a small high pass filter (50hz)

@BFCE
Copy link
Author

BFCE commented May 13, 2020

Version 2 of your edit is almost perfect if we still want to maintain parts of this effect, but given the ending (which is made up of much of the same frequencies) and the erratic behavior of it, I'm still not entirely convinced the effect was intentional in the first place. (Mind you, I don't think the ending ever actually plays in game. It loops before that section)

I should also note, you first start hearing the sounds around 10 seconds into the file, which is the section I've been using for comparison

@ItaloKnox
Copy link
Member

Looks like clyp is doing something to the music (probably replaygain?), so the issue kinda got lost on it. I edited the previous post with new links to Dropbox.

We also briefly talked about the possibility of adding your version to the installer as an optional download. That means people can choose between the original or your version that has the issue basically gone. That seems to be the most balanced option we have right now instead of going with a one size fits all approach. I'm okay with leaving my versions behind if that means we can make everyone happy.

@BFCE
Copy link
Author

BFCE commented May 13, 2020

That would be a good solution. I should also note that this sound file might be in the other Kai games as well. I haven't checked, as I only discovered this issue through actual gameplay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants