Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

Week 2 day 4 ex4 Plot_roc_curve is deprecated #29

Open
eslopfer opened this issue Aug 11, 2022 · 3 comments
Open

Week 2 day 4 ex4 Plot_roc_curve is deprecated #29

eslopfer opened this issue Aug 11, 2022 · 3 comments
Assignees

Comments

@eslopfer
Copy link
Contributor

When solving it I get a warning saying that Plot_roc_curve is deprecated and will be removed in future versions

@eslopfer eslopfer changed the title Week 2 day 4 ex4 Week 2 day 4 ex4 Plot_roc_curve is deprecated Aug 11, 2022
@brad-gh
Copy link
Contributor

brad-gh commented Aug 18, 2022

The packages are updated and inevitably some functions will be deprecated. I can mention it in the guidelines. What do you think ? @eslopfer

@eslopfer
Copy link
Contributor Author

I think that would be a reasonable option. We can ask @davhojt his opinion later on when having the meeting to confirm it.
The way I see it there are at least two options:

  • Update the content to the recommended methods: https://scikit-learn.org/stable/modules/generated/sklearn.metrics.plot_roc_curve.html
    • The trade-off would be having to monitor the content regularly to make sure it's kept up to date with new versions of the dependencies.
  • Mention the version being used and update the guidelines to specify that the student should use that specific version.
    • In this case the trade-off would be releasing content that is outdated from the very beginning.

What do you think? Can you think any other options? @brad-gh

@brad-gh
Copy link
Contributor

brad-gh commented Oct 14, 2022

TODO: Explain what to do when they get the warning deprecated in ex00

@brad-gh brad-gh self-assigned this Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants